From f8c27c211d0e0b9f357d625a15f7df77fcf27e60 Mon Sep 17 00:00:00 2001 From: DL6ER Date: Sat, 22 Feb 2025 09:01:17 +0100 Subject: [PATCH] Fix typo Signed-off-by: DL6ER --- src/config/config.c | 2 +- src/config/dnsmasq_config.c | 2 +- test/pihole.toml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/config/config.c b/src/config/config.c index c51a102f1..99c7811a6 100644 --- a/src/config/config.c +++ b/src/config/config.c @@ -502,7 +502,7 @@ static void initConfig(struct config *conf) conf->dns.expandHosts.c = validate_stub; // Only type-based checking conf->dns.domain.k = "dns.domain"; - conf->dns.domain.h = "The DNS domain used by your Pi-hole.\n\n This DNS domain in purely local. FTL may answer queries from its local cache and configuration but *never* forwards any requests upstream *unless* you have configured a dns.revServer exactly for this domain. In the latter case, all queries for this domain are sent exclusively to this server (including reverse lookups).\n\n For DHCP, this has two effects; firstly it causes the DHCP server to return the domain to any hosts which request it, and secondly it sets the domain which it is legal for DHCP-configured hosts to claim. The intention is to constrain hostnames so that an untrusted host on the LAN cannot advertise its name via DHCP as e.g. \"google.com\" and capture traffic not meant for it. If no domain suffix is specified, then any DHCP hostname with a domain part (ie with a period) will be disallowed and logged. If a domain is specified, then hostnames with a domain part are allowed, provided the domain part matches the suffix. In addition, when a suffix is set then hostnames without a domain part have the suffix added as an optional domain part. For instance, we can set domain=mylab.com and have a machine whose DHCP hostname is \"laptop\". The IP address for that machine is available both as \"laptop\" and \"laptop.mylab.com\".\n\n You can disable setting a domain by setting this option to an empty string."; + conf->dns.domain.h = "The DNS domain used by your Pi-hole.\n\n This DNS domain is purely local. FTL may answer queries from its local cache and configuration but *never* forwards any requests upstream *unless* you have configured a dns.revServer exactly for this domain. In the latter case, all queries for this domain are sent exclusively to this server (including reverse lookups).\n\n For DHCP, this has two effects; firstly it causes the DHCP server to return the domain to any hosts which request it, and secondly it sets the domain which it is legal for DHCP-configured hosts to claim. The intention is to constrain hostnames so that an untrusted host on the LAN cannot advertise its name via DHCP as e.g. \"google.com\" and capture traffic not meant for it. If no domain suffix is specified, then any DHCP hostname with a domain part (ie with a period) will be disallowed and logged. If a domain is specified, then hostnames with a domain part are allowed, provided the domain part matches the suffix. In addition, when a suffix is set then hostnames without a domain part have the suffix added as an optional domain part. For instance, we can set domain=mylab.com and have a machine whose DHCP hostname is \"laptop\". The IP address for that machine is available both as \"laptop\" and \"laptop.mylab.com\".\n\n You can disable setting a domain by setting this option to an empty string."; conf->dns.domain.a = cJSON_CreateStringReference(""); conf->dns.domain.t = CONF_STRING; conf->dns.domain.f = FLAG_RESTART_FTL; diff --git a/src/config/dnsmasq_config.c b/src/config/dnsmasq_config.c index 589954d47..f37f2c741 100644 --- a/src/config/dnsmasq_config.c +++ b/src/config/dnsmasq_config.c @@ -550,7 +550,7 @@ bool __attribute__((const)) write_dnsmasq_config(struct config *conf, bool test_ fputs("# DNS domain for both the DNS and DHCP server\n", pihole_conf); if(!domain_revServer) { - fputs("# This DNS domain in purely local. FTL may answer queries from\n", pihole_conf); + fputs("# This DNS domain is purely local. FTL may answer queries from\n", pihole_conf); fputs("# /etc/hosts or DHCP but should never forward queries on that\n", pihole_conf); fputs("# domain to any upstream servers\n", pihole_conf); fprintf(pihole_conf, "domain=%s\n", conf->dns.domain.v.s); diff --git a/test/pihole.toml b/test/pihole.toml index 4dd0e5670..082f39ae5 100644 --- a/test/pihole.toml +++ b/test/pihole.toml @@ -114,7 +114,7 @@ # The DNS domain used by your Pi-hole. # - # This DNS domain in purely local. FTL may answer queries from its local cache and + # This DNS domain is purely local. FTL may answer queries from its local cache and # configuration but *never* forwards any requests upstream *unless* you have # configured a dns.revServer exactly for this domain. In the latter case, all queries # for this domain are sent exclusively to this server (including reverse lookups).