Support phylogenies and phyloreferences that cannot be parsed #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phylogenies and phyloreferences can throw exceptions when you attempt to load them or convert them into JSON-LD/n-Quads, which we've previously ignored. This PR adds
try {} catch {}blocks around such invocations so that we can produce an error instead of having the entire Vue app crash. It also adds the download filename to the Advanced Modal dialog download button for completeness.Also includes a minor fix to the formatting of a few lines.
Closes #187.
Also checks for unbalanced single or double quotes in the Newick file as illustrated in this screenshot:
Closes #196.