Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of branch-based phyloreferences #344

Open
gaurav opened this issue Jan 29, 2025 · 0 comments
Open

Improve display of branch-based phyloreferences #344

gaurav opened this issue Jan 29, 2025 · 0 comments

Comments

@gaurav
Copy link
Member

gaurav commented Jan 29, 2025

We currently display all phyloreferences as originating on a note and including all of its descendants, but this is not technically correct, because branch-based phyloreferences should extend up to the previous node (but not include it). Actually drawing this will be technically difficult, so we'll leave this for a future version.

Some ideas from #315:

  • For branch-based phyloreference, we could add a symbol to the clade, and then add a note underneath the phylogeny to say that this is clade extends up the parent branch.
    • Note that qualifiers can render a node-based clade into a branch-based clade, so we might want to look for "maximum" or other text in the definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant