-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove baseIRI from n-Quads generation #231
Comments
This PR upgrades @phyloref/phyx.js to the latest version, allowing us to use reference-based (model 2.0) expectations (#65) and to export the ontology in n-Quads (#222). A few phyx.js methods have been renamed or replaced since this code was written; this PR updates them so that phyloref resolution works again. See #231 and #232 for some follow-up changes that will be needed after this PR. Closes #65, closes #204, closes #222.
Need to review. |
Both the "Export as ontology" button and the "Export as JSON-LD" button use this baseIRI, and I don't think there's an obvious way to work around this (see phyloref/phyx.js#113 for our efforts in phyx.js). I propose we make this configurable in the "Advanced" modal -- if a user wants to set this to blank and export a JSON-LD or n-triples file containing only relative references (e.g. |
Should we document this somewhere so that in the future we and others can remember why this is there? |
|
Because of phyloref/phyx.js#113, we need to include a baseIRI when generating n-Quads:
klados/src/components/sidebar/Sidebar.vue
Line 445 in 2e338c1
This issue a reminder to remove this once we fix this in phyx.js.
The text was updated successfully, but these errors were encountered: