Make sure an incorrect phylogeny doesn't break the rest of the UI #187
Comments
|
For example, |
gaurav
added
difficulty: easy
I'm not sure if it'll work for other cases, but it fixes that particular case.
|
The root problem is that PhylogenyWrapper can throw an exception (phyloref/phyx.js#116), which PhyxWrapper doesn't catch, and so it propagates up to us. The right solution is probably to modify the UI in order to display a banner at the top of the screen saying, "Phylogeny X is invalid and will be ignored.", and then implement some logic so that any invalid phylogenies are consistently ignored whenever PhyxWrapper is used, i.e. when exporting the Phyx file as JSON-LD or n-Triples in OWL. |
|
Might not need to be in milestone; please review. |
|
I am unable to replicate this now, so it looks like we've successfully caught the exceptions being generated. Closing. (Note that we still want to improve one of the error messages in #196, but that doesn't break the entire phylogeny.) |
|
This occurs on the master branch again, but PR #308 fixes it. |
Phylogenies and phyloreferences can throw exceptions when you attempt to load them or convert them into JSON-LD/n-Quads, which we've previously ignored. This PR adds `try {} catch {}` blocks around such invocations so that we can produce an error instead of having the entire Vue app crash. It also adds the download filename to the Advanced Modal dialog download button for completeness.
Also includes a minor fix to the formatting of a few lines and checks for unbalanced single or double quotes in the Newick file.
Closes #187.
Anna appears to have found a case where a malformed Newick string causes the phyloreference summary page to blank out because of an internal error. We should trap this and make sure the page can be rendered even with a malformed Newick string.
The text was updated successfully, but these errors were encountered: