Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name parsing libraries for scientific name-based taxonomic units #14

Open
gaurav opened this issue Mar 27, 2018 · 3 comments
Open

Comments

@gaurav
Copy link
Member

gaurav commented Mar 27, 2018

Currently, we use simple regular expressions to do this, but something like TaxaMatch would be better. There should also be a clear visual indicator to indicate that a name couldn't be parsed.

@hlapp
Copy link
Member

hlapp commented Mar 27, 2018

We might want to distinguish between name parsing and name matching. gnparser will probably work very well for the former. It sounds though that what you're really talking about here is matching, despite the title?

@gaurav
Copy link
Member Author

gaurav commented Mar 27, 2018

This issue (#14) covers name parsing, while #15 covers name matching/resolution. At the moment, we parse names with pretty simple regular expressions, so TaxaMatch or gnparser would be a step up from that and would be able to handle much more complicated names.

However, maybe we don't need anything that advanced just yet, while comparing our names to taxonomic authorities would immediately highlight typos and other resolution errors. I wanted to file them separately so we could prioritize them separately.

@gaurav
Copy link
Member Author

gaurav commented Feb 27, 2019

Name parsing should take place in phyx.js, so I've created an issue to cover that at phyloref/phyx.js#7. Displaying and editing the results of the parsing is covered by #16. The Curation Tool should really not be doing any name parsing at all, although it should support looking up names and specimens on biodiversity databases (#15). I therefore think we should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants