New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding PATTERN_FROM_STRING #24

Open

troseman opened this issue Mar 21, 2018 · 0 comments

troseman commented Mar 21, 2018

I need a slightly different string pattern for fromString().

Suggest making Fraction.php.357 static::PATTERN_FROM_STRING instead of self: so can be overridden in subclass. Or make protected getter function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment