From 39edd23c79b5b5a09ba17c59088b5b6919d75b67 Mon Sep 17 00:00:00 2001 From: Matthew Weier O'Phinney Date: Tue, 15 Sep 2020 14:48:33 -0500 Subject: [PATCH] fix: ensure tag name is set when version discovered When running `release:tag`, the tag name was not getting set once the version was discovered, which was leading to an error indicating no tag name was provided. --- src/Version/DiscoverVersionEventTrait.php | 1 + src/Version/ReleaseEvent.php | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/Version/DiscoverVersionEventTrait.php b/src/Version/DiscoverVersionEventTrait.php index 2ae20e0d..35051d1f 100644 --- a/src/Version/DiscoverVersionEventTrait.php +++ b/src/Version/DiscoverVersionEventTrait.php @@ -15,6 +15,7 @@ trait DiscoverVersionEventTrait public function foundVersion(string $version): void { $this->version = $version; + $this->tagName = $this->tagName ?: $version; } public function versionNotAccepted(): void diff --git a/src/Version/ReleaseEvent.php b/src/Version/ReleaseEvent.php index 79292e79..009a2146 100644 --- a/src/Version/ReleaseEvent.php +++ b/src/Version/ReleaseEvent.php @@ -77,12 +77,6 @@ public function setReleaseName(string $releaseName): void $this->releaseName = $releaseName; } - public function foundVersion(string $version): void - { - $this->version = $version; - $this->tagName = $this->tagName ?: $version; - } - public function releaseCreated(string $release): void { $this->output()->writeln(sprintf('Created %s', $release));