Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap Modal on Desktop should scroll on short screens #531

Open
tomporvaz opened this issue Sep 8, 2024 · 1 comment
Open

Tap Modal on Desktop should scroll on short screens #531

tomporvaz opened this issue Sep 8, 2024 · 1 comment

Comments

@tomporvaz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The tap modal should fit on smaller screen and give the user the ability to scroll through the details with in the modal. Currently, if the modal expands beyond the bounds of the screen, the full window scrolls showing the user space outside of the map.

image

Describe the solution you'd like
Instead, the modal should fit fully with in the screen and the modal should have a scroll bar that allows the user to scroll down to see additional information.

Describe alternatives you've considered
n/a

Additional context
n/a

@tomporvaz tomporvaz added the Version 2 Features to be developed for Version 2.0 of the PHLASK App label Sep 8, 2024
@tomporvaz tomporvaz moved this to 🔖 Ready in Phlask Map Sep 8, 2024
@gcardonag
Copy link
Contributor

@tomporvaz I took a jab at minimizing the risk of scrolling in this context with this PR: #543

That said, it doesn't completely eliminate scrolling. I think we can defer a better fix to a post-2.0 version with this in place

@gcardonag gcardonag removed the Version 2 Features to be developed for Version 2.0 of the PHLASK App label Oct 30, 2024
@gcardonag gcardonag assigned gcardonag and unassigned gcardonag Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants