Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-blocking functionality #47

Closed
GenericNerd opened this issue Apr 7, 2024 · 5 comments · Fixed by #48
Closed

Add non-blocking functionality #47

GenericNerd opened this issue Apr 7, 2024 · 5 comments · Fixed by #48

Comments

@GenericNerd
Copy link

Currently, the library is not non-blocking and causes errors with tokio as a runtime is being created during execution. This could potentially be resolved through spawning the DNS portion with a call to tokio::task::spawn_blocking
@phip1611
Copy link
Owner

phip1611 commented Apr 7, 2024

Which errors do occur inside a tokio runtime?

My time currently is limited, so I can't promise anything right away

@GenericNerd
Copy link
Author

Which errors do occur inside a tokio runtime?

My time currently is limited, so I can't promise anything right away

It shows that another runtime cannot be started, I don't have the exact error to hand, but it happens in the DNS portion

@phip1611 phip1611 mentioned this issue Apr 9, 2024
Merged
@phip1611
Copy link
Owner

phip1611 commented Apr 9, 2024

Fixing it in 0883c59 / #48

@phip1611
Copy link
Owner

phip1611 commented Apr 9, 2024

Will be released soon in v1.11

@phip1611
Copy link
Owner

phip1611 commented Apr 10, 2024 •
edited
Loading

It's released on crates.io and in nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prepare v1.11 phip1611/ttfb
2 participants
@phip1611 @GenericNerd