Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt pre-commit does not exist in perennial/perennial-alias #421

Open
samreid opened this issue Dec 4, 2024 · 3 comments
Open

grunt pre-commit does not exist in perennial/perennial-alias #421

samreid opened this issue Dec 4, 2024 · 3 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Dec 4, 2024

While working on #412 I observed that you cannot run grunt pre-commit in perennial. Instead you have to run sage run ../chipper/js/grunt/tasks/pre-commit.ts. @zepumph how should we proceed?

@zepumph
Copy link
Member

zepumph commented Dec 10, 2024

I want to discuss this a bit more. It should be up to the repo to determine what tasks it supports. Likely we will need some logic in chipper and some in perennial though, since lint-all is appropriate in chipper, but in perennial it should just be lint. Same for report-media.

@samreid
Copy link
Member Author

samreid commented Dec 17, 2024

In discussion with @zepumph, we think it would be nice for perennial to have grunt pre-commit with a subset of steps that are appropriate for perennial. Then chipper can layer on more tasks that are appropriate for that level.

But we also saw that perennial's precommit hooks run out of chipper, and that is not good. So we should schedule time to work on this.

@samreid
Copy link
Member Author

samreid commented Dec 19, 2024

For me, the important part is that precommit hooks still run, and you can run them with sage run. I'm not planning to work on this independently, but let me know if you would like assistance or collaboration. Self-unassigning until then.

@samreid samreid removed their assignment Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants