Add Tier 1 Description

[marlitas]

Accessible names have been defined here

[marlitas]

I did a first pass on this. I was unable to find any final decisions in the design doc, it seems like there were a lot of questions still in the air. We should get this to @terracoda asap since I believe there might be some back and forth here. @catherinecarter I'll let you connect with TS to start that conversation.

[catherinecarter]

Meeting with TS/CC on Feb. 3, 2025

Name	Accessible Name	Help Text
	Read Phrase	Read number phrase aloud.
	Organize {{Apples}} (Is it possible to make the object name dynamic?)	Organize {{objects}} into rows of five.(If possible, can this also be dynamic?)
	Organize Beads	Organize beads into groups of five.
	Swap Addends	N/A
	For location-based representations  When hiding: * Hide Left Addend * Hide Right Addend When revealing: * Show Left Addend * Show Right Addend For beads, kitten, number line: When hiding: * Hide Addends When showing: * Show Addends	Question for MS: Is this implemented as a toggle button? If so, the state will say whether the button is pressed or not pressed. If not, then use the names on the left For location-based: * Show or hide the objects and the value of the addend. For other: * Show or hide the objects and values for both addends.
	A-B switch is in common code and is sonified. So... A, Switch to B and B, Switch to A, we will consider A to be the left side of the toggle. Name A to be, "Count On"; Name B to be, "Count from Zero"	N/A
Scene selection radio button group	Change to: Total Number [H3]	Choose total for counting area.
	Change “One Cards” to be “Ones”	Choose representation for counting area.
	Change “Number Sentence” to be “Phrase”The “Number Bond” needs to be dynamic and change to say, “Bar Model” when chosen in preferences.
Total Checkbox on Sum screen		Show or hide the sum of the two addends.

[terracoda]

Name for A-B Switch
@Marla, @catherinecarter and I came up with a good name for the A-B Switch that appears under the number line.
It follows the pattern already in common code, and it does not need help text.

• Count On, Switch to Count from Zero

• Count from Zero, Switch to Count On

I updated the row in the table in comment #78 (comment)

In the sun repo, I drafted a quick design pattern for A-B Switch (still in progress when time is allowed). Have a look if you like.

[terracoda]

@catherinecarter, for the "Show/Hide" checkboxes, it is better to explain the showing and hiding in the help text, and just use the visual name.

@marlitas, these name are already correctly implemented (maybe automatically)!

Re "Tick Numbers", did you consider "Numbered Tick Marks"? We used that name in Ratio and Proportion, but that sim also has a "No Tick Marks" option.

For help text, here are some suggestions:
Addends checkbox:

• Explore with or without addends on number line.
• Explore with or without addend labels on number line.
• Explore number line with or without addend labels.

Ticks checkbox:

• Explore with or with without numbered tick marks. (likely works with either name)
• Explore number line with or with without numbered tick marks.

Total Jump checkbox

• Explore with or without total jump on number line.
• Explore number line with or with out total jump.

@catherinecarter, If there is a clear section in the PDOM, like a heading that names the board area, then we may not need "number line" in the help text, but as is with no heading for the board, that word connects the checkboxes with changing the representations on the number line.

[marlitas]

Is this implemented as a toggle button? If so, the state will say whether the button is pressed or not pressed. If not, then use the names on the left For location-based: * Show or hide the objects and the value of the addend. For other: * Show or hide the objects and values for both addends.

@catherinecarter and @terracoda It is now implemented as a toggle button but I'm not following the instructions here. Am I relying on the state of the component because it's a toggle and I just provide one accessible name that doesn't change?

[marlitas]

I also updated the chart to reflect the checkbox change @terracoda mentioned above

[marlitas]

Accessible name and help text notes applied above. Over to @catherinecarter and @terracoda for review.

[terracoda]

@marlitas, you need to use the new A-B Switch pattern we created for MoTHA. The pattern is in common code.

This interaction needs 2 unique names. While it is a toggle interaction, it is not a traditional toggle button that automatically provides pressed and not-pressed states to screen reader software.

[marlitas]

@terracoda the only ABSwitch I see in MOTHA is not explicitly setting any accessibleNames, only help text:

    super( experimentOrModelProperty, 'experiment', experimentText, 'model', modelText, {
      isDisposable: false,
      centerOnSwitch: false,
      toggleSwitchOptions: {
        size: new Dimension2( 50, 25 ),
        phetioVisiblePropertyInstrumented: false,
        phetioEnabledPropertyInstrumented: false
      },
      helpText: ModelsOfTheHydrogenAtomStrings.a11y.experimentOrModelHelpTextSwitch.helpTextStringProperty,
      tandem: tandem
    } );

I have used the following options I found in ABSwitch to create what you are seeing/hearing.

  // Accessible names for each value. They will be inserted into a pattern string for the accessible name
  // of the ABSwitch. If not provided, ABSwitch will try to find default values from the label Nodes. The
  // final string will look like:
  // "{{valueAAccessibleName}}, Switch to {{valueBAccessibleName}}"
  valueAAccessibleName?: TReadOnlyProperty<string> | string | null;
  valueBAccessibleName?: TReadOnlyProperty<string> | string | null;

Are these not the correct options? If so they should be updated or marked as deprecated.

My options for the ABSwitch below. As you can see valueAAccessibleName and valueBAccessibleName have been defined with the strings I was provided above.

{
          top: COUNTING_AREA_BOUNDS.bottom + COUNTING_AREA_Y_MARGIN,
          left: COUNTING_AREA_BOUNDS.left,
          visibleProperty: numberLineVisibleProperty,
          valueAAccessibleName: NumberPairsStrings.countOnStringProperty,
          valueBAccessibleName: NumberPairsStrings.countFromZeroStringProperty,
          toggleSwitchOptions: {
            size: new Dimension2( 36, 18 )
          },
          tandem: options.tandem.createTandem( 'leftAddendLabelPlacementSwitch' )
        } );

[marlitas]

@terracoda it looks like phet-test might be down so you might have been looking at an outdated version. https://phetsims.slack.com/archives/C6HPE0J91/p1738947351565259

[terracoda]

Issues Screen 1:

• Organize button's name is not yet dynamic. I just hear Organize Apples.
• "Show or Hide Addend" buttons need dynamic names that describe their state: - Hide Addend (when not hidden) and Show Addend (When hidden).
• "Hear Number Sentence" - @Cathy the accordion now say "Number Phrase", so maybe the Horn button should be "Hear Number Phrase"?
• "Total Number 3" is not the correct name for the list of numbers. That radio group is not in the table. I suggest:
  • group name: Total Number
  • help text: Choose total number of current representation for counting area.
• We need to discuss a description design (names and help text) for the counting area.

Haven't done other screens yet.

[marlitas]

"Total Number 3" is not the correct name for the list of numbers. That radio group is not in the table.

@terracoda This is what we defined for the scene selection radio button group which is the UI component you are referring to. Should I change it?

Scene selection radio button group	Change to: Total Number [H3]	Choose total for counting area.

We need to discuss a description design (names and help text) for the counting area.

@catherinecarter and @terracoda do we need to set up a meeting for that?

[catherinecarter]

I need to look through this issue more thoroughly, but one thing I noticed is that when a kitten is selected using keyboard, the a11y view says, "null, switch to null."

Documenting to make sure this is discussed.