Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum screen needs a "Total" checkbox for all representations #71

Open
catherinecarter opened this issue Jan 17, 2025 · 7 comments
Open

Comments

@catherinecarter
Copy link

On the Sum screen, there is a "Total" checkbox missing. It should go where the "Total Jump" checkbox is on the previous four screens, but should say, "Total" instead, and should default to unchecked.

Image

So for the Beads and Kittens representations, the only checkbox under the equation will be the "Total," and for the Number Line, the other checkboxes will be present, like the other screens. The addends and tick marks will default on while the total checkbox will default off, and the arrow/total jump + value will appear when the Total checkbox is checked.

Image
@marlitas
Copy link
Contributor

marlitas commented Feb 4, 2025

Done above. @catherinecarter over to your for review. Feel free to close if all looks well :-)

@catherinecarter
Copy link
Author

Works really well, nice!

My only noticing is that we could align the left edge of the checkbox with the left edge of the accordion box. Might look a little cleaner.

Image

@marlitas
Copy link
Contributor

My only noticing is that we could align the left edge of the checkbox with the left edge of the accordion box. Might look a little cleaner.

We would have to make the maxWidth smaller, which I can totally do, but maybe play with the queryParamter ?stringTest=dynamic and see if that feels appropriate to you.

@marlitas marlitas assigned catherinecarter and unassigned marlitas Feb 12, 2025
@catherinecarter
Copy link
Author

Thanks, I'll do that. I actually tried to change the language that has longer words, but the checkbox labels aren't translating at the moment. I forgot about stringTest - thanks!

@marlitas
Copy link
Contributor

the checkbox labels aren't translating at the moment.

Yeah they won't translate until we publish and we get translations in. stringTest is really the only way to check before publishing.

@catherinecarter
Copy link
Author

Yes, let's reduce the maxWidth so the checkbox is left aligned with the accordion box. Thanks!

marlitas added a commit that referenced this issue Feb 14, 2025
@marlitas
Copy link
Contributor

Adjusted above. @catherinecarter feel free to close if it looks good!

@marlitas marlitas assigned catherinecarter and unassigned marlitas Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants