diff --git a/Iceberg-Tests/IceBasicRepositoryFixture.class.st b/Iceberg-Tests/IceBasicRepositoryFixture.class.st index c299f52fe4..be9b189b83 100644 --- a/Iceberg-Tests/IceBasicRepositoryFixture.class.st +++ b/Iceberg-Tests/IceBasicRepositoryFixture.class.st @@ -26,6 +26,13 @@ IceBasicRepositoryFixture class >> inMemory [ yourself ] +{ #category : 'private' } +IceBasicRepositoryFixture >> deleteAllForcingClose [ + + self repository free. + super deleteAllForcingClose +] + { #category : 'initialization' } IceBasicRepositoryFixture >> initialize [ super initialize. diff --git a/Iceberg-Tests/IceClonedFromRemoteFixture.class.st b/Iceberg-Tests/IceClonedFromRemoteFixture.class.st index af978de2a0..9995d2743d 100644 --- a/Iceberg-Tests/IceClonedFromRemoteFixture.class.st +++ b/Iceberg-Tests/IceClonedFromRemoteFixture.class.st @@ -12,6 +12,13 @@ Class { #tag : 'Common-Fixtures' } +{ #category : 'private' } +IceClonedFromRemoteFixture >> deleteAllForcingClose [ + + self repository free. + super deleteAllForcingClose +] + { #category : 'accessing' } IceClonedFromRemoteFixture >> pushRepository [ ^ pushRepository diff --git a/Iceberg-Tests/IceGitTestFactory.class.st b/Iceberg-Tests/IceGitTestFactory.class.st index 0e3bf7b59c..f96ead93ef 100644 --- a/Iceberg-Tests/IceGitTestFactory.class.st +++ b/Iceberg-Tests/IceGitTestFactory.class.st @@ -109,6 +109,7 @@ IceGitTestFactory >> tearDownWithRepository: aRepository [ aRepository ifNotNil: [ aRepository free. + Smalltalk garbageCollect. [ aRepository location ifNotNil: #ensureDeleteAll ] on: CannotDeleteFileException do: [ "On windows it is possible we need to finalize everything before deleting the files. We do not do it directly to avoid to lose too much speed" diff --git a/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st b/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st index 9e39cd0a43..4f66b870fe 100644 --- a/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st +++ b/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st @@ -30,6 +30,15 @@ IceNotYetClonedRepositoryFixture class >> inMemory [ yourself ] +{ #category : 'private' } +IceNotYetClonedRepositoryFixture >> deleteAllForcingClose [ + "On windows it is possible we need to finalize everything before deleting the files. + We do not do it directly to avoid to lose too much speed" + + Smalltalk garbageCollect. + self location ifNotNil: #ensureDeleteAll +] + { #category : 'initialization' } IceNotYetClonedRepositoryFixture >> ensureRemoteRepository [ @@ -111,7 +120,8 @@ IceNotYetClonedRepositoryFixture >> tearDown [ [ self location ifNotNil: #ensureDeleteAll ] on: CannotDeleteFileException - do: [ "On windows it is possible we need to finalize everything before deleting the files. We do not do it directly to avoid to lose too much speed" - Smalltalk garbageCollect. - self location ifNotNil: #ensureDeleteAll ] + do: [ + "On windows it is possible we need to finalize everything before deleting the files. + We do not do it directly to avoid to lose too much speed" + self deleteAllForcingClose ] ] diff --git a/Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st b/Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st index cca0e7a583..96e2c3c74f 100644 --- a/Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st +++ b/Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st @@ -58,7 +58,8 @@ IceTipInteractiveErrorVisitor >> repository: anObject [ { #category : 'visiting' } IceTipInteractiveErrorVisitor >> visitAuthenticationError: anError [ - context application + + context application newInform label: anError messageText; title: 'Iceberg authentication Error'; openModal diff --git a/Iceberg-UI-Tests/IceTipCommitBrowserTest.class.st b/Iceberg-UI-Tests/IceTipCommitBrowserTest.class.st index aac1dd06ff..39a4c218e2 100644 --- a/Iceberg-UI-Tests/IceTipCommitBrowserTest.class.st +++ b/Iceberg-UI-Tests/IceTipCommitBrowserTest.class.st @@ -39,6 +39,7 @@ IceTipCommitBrowserTest >> setUp [ { #category : 'running' } IceTipCommitBrowserTest >> tearDown [ + presenter ifNotNil: [ presenter window close ]. super tearDown ] @@ -154,6 +155,7 @@ IceTipCommitBrowserTest >> testIsCommittingWithTheRightMessage [ { #category : 'tests' } IceTipCommitBrowserTest >> testIsNotAutomaticallySavingWhenNotChecked [ | previousState | + previousState := presenter commentPanel isSaving. presenter commentPanel saveOnCommit: false. [