Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RB] Breaking Change in Instance Variable Refactor #17590

Open
jordanmontt opened this issue Jan 9, 2025 · 2 comments
Open

[RB] Breaking Change in Instance Variable Refactor #17590

jordanmontt opened this issue Jan 9, 2025 · 2 comments

Comments

@jordanmontt
Copy link
Member

When you rename an instance variable that has getter and setter methods, the refactor silently removes those methods and creates new ones with the new instance variable name.

This happens only if there are no current uses of the old methods in the current project. However, the old methods might still be used in other packages that aren't currently loaded.

This means the refactor could cause problems, making it more like a transformation than a simple rename because it can break code.

@Ducasse
Copy link
Member

Ducasse commented Jan 10, 2025

Thanks seb we will have a look.

@Ducasse Ducasse changed the title Breaking Change in Instance Variable Refactor [RB] Breaking Change in Instance Variable Refactor Jan 10, 2025
@Ducasse
Copy link
Member

Ducasse commented Jan 10, 2025

So it means that the current implementation is wrong.
It should only add the new setters and getters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants