Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

both implementations should offer the same API #2

Open
Ducasse opened this issue May 4, 2018 · 2 comments
Open

both implementations should offer the same API #2

Ducasse opened this issue May 4, 2018 · 2 comments

Comments

@Ducasse
Copy link
Collaborator

Ducasse commented May 4, 2018

No description provided.

@Ducasse
Copy link
Collaborator Author

Ducasse commented Dec 21, 2022

The package contains two different implementations and we should assess whether this is worth or at least align the API.

@privat
Copy link
Contributor

privat commented Dec 21, 2022

Both implementation should document the difference, and possibly inherit from a common abstract super class is it makes sense.

Or just drop one of the two implementations if clearly inferior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@privat @Ducasse