Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly error lists when multiple errors are present on a sample sheet validation #4

Open
JeffreyThiessen opened this issue Jan 29, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@JeffreyThiessen
Copy link
Member

Errors should be human readable, currently the whole array is written to string, [ and ] included.

@JeffreyThiessen JeffreyThiessen added the bug Something isn't working label Jan 31, 2019
@JeffreyThiessen
Copy link
Member Author

Because we are using the ugly errors as the base for what we write to the status file they can look really ugly sometimes.

ex:

{
    "Date Time": "2019-05-16 14:47",
    "Message": "ERROR! Could not initialize irida api. Errors: ('Could not get access token from IRIDA. Credentials may be incorrect. IRIDA '\n \"returned with error message: ('Decoder failed to handle access_token with \"\n 'data as returned by provider. A different decoder may be needed. Provider '\n 'returned: b\\\\\\'{\"error\":\"invalid_client\",\"error_description\":\"Bad client '\n 'credentials\"}\\\\\\'\\',)',)",
    "Upload Status": "error"
}

@JeffreyThiessen
Copy link
Member Author

Since we are storing json we should just change to the object to include an errors list. Then when pretty printed it will look cleaner automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant