From e29ced98f9984192d0b03470a60f44d5fb21ccb7 Mon Sep 17 00:00:00 2001 From: Josh Adam Date: Thu, 30 Jan 2025 07:14:22 -0600 Subject: [PATCH] test: Update samples test to use metadata template select dropdown Replace metadata toggle label click with select dropdown interaction across multiple test scenarios, ensuring consistent test coverage for the new metadata template selection method --- test/system/projects/samples_test.rb | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/test/system/projects/samples_test.rb b/test/system/projects/samples_test.rb index 63886bb74b..cf6d6c988b 100644 --- a/test/system/projects/samples_test.rb +++ b/test/system/projects/samples_test.rb @@ -1097,7 +1097,8 @@ class SamplesTest < ApplicationSystemTestCase assert_text strip_tags(I18n.t(:'viral.pagy.limit_component.summary', from: 1, to: 3, count: 3, locale: @user.locale)) # toggle metadata on for samples table - find('label', text: I18n.t(:'projects.samples.shared.metadata_toggle.label')).click + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') + within('#samples-table table thead tr') do assert_selector 'th', count: 8 end @@ -1167,7 +1168,7 @@ class SamplesTest < ApplicationSystemTestCase assert_text strip_tags(I18n.t(:'viral.pagy.limit_component.summary', from: 1, to: 3, count: 3, locale: @user.locale)) # toggle metadata on for samples table - find('label', text: I18n.t(:'projects.samples.shared.metadata_toggle.label')).click + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') within('#samples-table table thead tr') do assert_selector 'th', count: 8 end @@ -2487,7 +2488,8 @@ class SamplesTest < ApplicationSystemTestCase assert_no_selector 'div#spinner' assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1 - find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click + + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') assert_selector 'div#spinner' assert_no_selector 'div#spinner' @@ -2534,7 +2536,8 @@ class SamplesTest < ApplicationSystemTestCase visit namespace_project_samples_url(subgroup12aa, project31) assert_selector 'table thead tr th', count: 6 - find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') + assert_selector 'table thead tr th', count: 8 click_on I18n.t('projects.samples.show.table_header.last_updated') @@ -2564,7 +2567,7 @@ class SamplesTest < ApplicationSystemTestCase login_as users(:ryan_doe) visit namespace_project_samples_url(@namespace, @project) - find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') within('table thead tr') do assert_selector 'th', count: 7 end @@ -2597,8 +2600,7 @@ class SamplesTest < ApplicationSystemTestCase assert_selector 'div#spinner' assert_no_selector 'div#spinner' - assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1 - find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') assert_selector 'div#spinner' assert_no_selector 'div#spinner' @@ -2657,8 +2659,7 @@ class SamplesTest < ApplicationSystemTestCase assert_selector 'div#spinner' assert_no_selector 'div#spinner' - assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1 - find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click + select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]') assert_selector 'div#spinner' assert_no_selector 'div#spinner'