Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output list of tiles that didn't match #59

Open
dankein opened this issue Nov 22, 2018 · 4 comments
Open

Output list of tiles that didn't match #59

dankein opened this issue Nov 22, 2018 · 4 comments

Comments

@dankein
Copy link

dankein commented Nov 22, 2018

Would it be possible to generate an additional output for troubleshooting that is a list of tiles where there were no positive or negative matches for each sample?

@glabbe
Copy link
Collaborator

glabbe commented Nov 23, 2018

That is a good suggestion!

@mgopez
Copy link
Member

mgopez commented Nov 23, 2018

Sounds like a great idea, I'll have a look and see how we can implement this into the tool. Is that okay with you @peterk87?

@peterk87
Copy link
Contributor

Hi @dankein

What do you think of a matrix (tiles by samples) of tile absence/presence?

Something like

Samples tile 1 tile 2 tile 3 ... tile X
sample 1 1 1 0 ... 1
sample 2 0 1 0 ... 0
sample 3 1 0 1 ... 1

Presence/absence could be represented with 1/0 or true/false or something else.

@dankein
Copy link
Author

dankein commented Nov 23, 2018

Hi @peterk87, good idea, I like this if it can accommodate both positive and negative tiles. Positive and negative represented separately, or with a match to either a positive or negative represented as a 1 would work. I think this would make troubleshooting / QCing a new tile set easier in my view.

My original thought was a bit simpler - a mirror of the match_results- maybe just (file_path, ref position and sample columns) for the tiles that didn't match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants