Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint axis restricted to one of the frame axis #253

Closed
gianluca-garofalo opened this issue Jun 29, 2021 · 5 comments
Closed

Joint axis restricted to one of the frame axis #253

gianluca-garofalo opened this issue Jun 29, 2021 · 5 comments
Assignees
Labels

Comments

@gianluca-garofalo
Copy link

While using Swift, I have noticed that a URDF file containing a joint axis that is not aligned with one of the three frame axis (either x, y or z) gets the wrong number of DoFs. Although I noticed this while using Swift, I suspect that it might be due to this part of the code:

if joint.joint_type in ('revolute', 'continuous'): # pragma nocover # noqa

If I am correct, do you have a suggestion on how to fix this issue that does not involve changing the URDF?
Thank you in advance for your support and of course for sharing your code!

@jhavl
Copy link
Collaborator

jhavl commented Jul 19, 2021

Hey @gianluca-garofalo could you please provide an example of a URDF which produces this issue? Then I can have a look at what we can do about it.

@gianluca-garofalo
Copy link
Author

Hi @jhavl,

Using just one joint should already be enough. I have attached a minimal example, that I hope shows what I was referring to. If you change the axis to "1 0 0", the test is visualized correctly, while the axis in the attached URDF yields an error.
My guess is that the URDF parser does not recognize an axis that is not x, y or z; that is why I pointed to the code line in my previous message.

Please, do let me know if I can support you somehow.

Thank you for your looking into it.
Gianluca

issue253.zip

jhavl added a commit that referenced this issue Sep 13, 2021
@jhavl
Copy link
Collaborator

jhavl commented Sep 13, 2021

Sorry for the delay, I've implemented a fix, let me know if it works as expected.

@jhavl jhavl closed this as completed Sep 13, 2021
@wildthingz
Copy link

Hello,

I'd like to re-open this issue. I don't think this is resolved.

While moving a revolute joint with a tilted <axis xyz="0 0.866025 -0.5"/> for instance I only see movement in one direction (i.e. z driection).

Cheers,

Hatef

@2lian
Copy link

2lian commented May 20, 2024

Hello,

I discovered this closed issue after I made my pull request. The issue is still here in the current version. You can find my (quite long) fix in this pull request:
#441

I hope it will help someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants