Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXC backup and restore job pods do not bear the classic app.kubernetes.io/* labels used by other components #1673

Open
konoox opened this issue Mar 14, 2024 · 1 comment
Labels

Comments

@konoox
Copy link

konoox commented Mar 14, 2024

Report

PXC backup and restore job pods do not bear the classic app.kubernetes.io/* labels used by other components

More about the problem

When a new pxc cluster is deployed, all the running pod related are automatically created with these usefull labels :

app.kubernetes.io/component=<pxc/haproxy/proxysql/pitr>
app.kubernetes.io/instance=<cr.Name>
app.kubernetes.io/managed-by=percona-xtradb-cluster-operator
app.kubernetes.io/name=percona-xtradb-cluster
app.kubernetes.io/part-of=percona-xtradb-cluster

But it is not the case for the backup and restore jobs pods, even if it's possible to add custom labels for backup in the spec.backup.storages..labels section of the CR definition but nothing for restore as far as I know.
Anyway, it would be a great improvement to automatically add these labels for the backup and restore pods as it already the case with the PostgreSQL operator.

Steps to reproduce

1 - Create a pxc cluster with a backup storage configured without additional label in the definition
2 - Run a pxc backup of the cluster
3 - See that the backup job pod does not bear the classic app.kubernetes.io/* labels
4 - Run a pxc restore on the cluster
5 - See that the restore job pod does not bear the classic app.kubernetes.io/* labels neither

Versions

1 - Kubernetes - v1.27.6
2 - Operator - Percona Operator for MySQL based on Percona XtraDB Cluster 1.13.0
3 - Database - MySQL XtraDB 8.0

Anything else?

No response

@konoox konoox added the bug label Mar 14, 2024
@spron-in
Copy link
Collaborator

spron-in commented Apr 1, 2024

@konoox thanks for sharing. We will fix it in https://perconadev.atlassian.net/browse/K8SPXC-1378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants