From e30ee5a3e240f1405df7f90192ce80f37c2f71d0 Mon Sep 17 00:00:00 2001
From: Bastian Triller <bastian.triller@gmail.com>
Date: Tue, 21 Jan 2025 12:27:52 +0100
Subject: [PATCH] OS/Network_Details: Fix TCP counters

* Show rate for counter metrics
* Show established gauge on own axis
---
 dashboards/OS/Network_Details.json | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/dashboards/OS/Network_Details.json b/dashboards/OS/Network_Details.json
index f9e4747c92..2170a07394 100644
--- a/dashboards/OS/Network_Details.json
+++ b/dashboards/OS/Network_Details.json
@@ -1409,7 +1409,12 @@
       "pointradius": 5,
       "points": false,
       "renderer": "flot",
-      "seriesOverrides": [],
+      "seriesOverrides": [
+        {
+          "alias": "established",
+          "yaxis": 2
+        }
+      ],
       "spaceLength": 10,
       "stack": false,
       "steppedLine": false,
@@ -1426,7 +1431,7 @@
           "target": ""
         },
         {
-          "expr": "max_over_time(node_netstat_Tcp_ActiveOpens{node_name=~\"$node_name\"}[$interval]) or\nmax_over_time(node_netstat_Tcp_ActiveOpens{node_name=~\"$node_name\"}[5m])",
+          "expr": "irate(node_netstat_Tcp_ActiveOpens{node_name=~\"$node_name\"}[$interval]) or\nirate(node_netstat_Tcp_ActiveOpens{node_name=~\"$node_name\"}[5m])",
           "format": "time_series",
           "interval": "$interval",
           "intervalFactor": 1,
@@ -1436,7 +1441,7 @@
           "step": 40
         },
         {
-          "expr": "max_over_time(node_netstat_Tcp_PassiveOpens{node_name=~\"$node_name\"}[$interval]) or\nmax_over_time(node_netstat_Tcp_PassiveOpens{node_name=~\"$node_name\"}[5m])",
+          "expr": "irate(node_netstat_Tcp_PassiveOpens{node_name=~\"$node_name\"}[$interval]) or\nirate(node_netstat_Tcp_PassiveOpens{node_name=~\"$node_name\"}[5m])",
           "format": "time_series",
           "interval": "$interval",
           "intervalFactor": 1,
@@ -1446,7 +1451,7 @@
           "step": 40
         },
         {
-          "expr": "max_over_time(node_netstat_Tcp_EstabResets{node_name=~\"$node_name\"}[$interval]) or\nmax_over_time(node_netstat_Tcp_EstabResets{node_name=~\"$node_name\"}[5m])",
+          "expr": "irate(node_netstat_Tcp_EstabResets{node_name=~\"$node_name\"}[$interval]) or\nirate(node_netstat_Tcp_EstabResets{node_name=~\"$node_name\"}[5m])",
           "format": "time_series",
           "interval": "$interval",
           "intervalFactor": 1,
@@ -1456,7 +1461,7 @@
           "step": 40
         },
         {
-          "expr": "max_over_time(node_netstat_Tcp_AttemptFails{node_name=~\"$node_name\"}[$interval]) or\nmax_over_time(node_netstat_Tcp_AttemptFails{node_name=~\"$node_name\"}[5m])",
+          "expr": "irate(node_netstat_Tcp_AttemptFails{node_name=~\"$node_name\"}[$interval]) or\nirate(node_netstat_Tcp_AttemptFails{node_name=~\"$node_name\"}[5m])",
           "format": "time_series",
           "interval": "$interval",
           "intervalFactor": 1,
@@ -1466,7 +1471,7 @@
           "step": 40
         },
         {
-          "expr": "max_over_time(node_netstat_Tcp_RetransSegs{node_name=~\"$node_name\"}[$interval]) or\nmax_over_time(node_netstat_Tcp_RetransSegs{node_name=~\"$node_name\"}[5m])",
+          "expr": "irate(node_netstat_Tcp_RetransSegs{node_name=~\"$node_name\"}[$interval]) or\nirate(node_netstat_Tcp_RetransSegs{node_name=~\"$node_name\"}[5m])",
           "format": "time_series",
           "interval": "$interval",
           "intervalFactor": 1,