Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view: implement subaccount filtering for ownedPositionIds #1989

Closed
erwanor opened this issue Jan 22, 2025 · 1 comment · Fixed by #2006
Closed

view: implement subaccount filtering for ownedPositionIds #1989

erwanor opened this issue Jan 22, 2025 · 1 comment · Fixed by #2006
Assignees
@VanishMax
Labels
priority Important to work on next

Comments

@erwanor
Copy link
Member

erwanor commented Jan 22, 2025

Is your feature request related to a problem? Please describe.
In penumbra-zone/penumbra#4992 we amended the Penumbra view protocol protos to incorporate an optional account filter in the OwnedPositionIds RPC of the View service.

Describe the solution you'd like
Implement this RPC in the web view service so that the DEX explorer can do proper segmentation by sub-account.
@erwanor erwanor added the priority Important to work on next label Jan 22, 2025
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jan 22, 2025
@erwanor erwanor moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Jan 22, 2025
@erwanor
Copy link
Member Author

erwanor commented Jan 22, 2025

Buf docs: https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.view.v1#penumbra.view.v1.OwnedPositionIdsRequest

@VanishMax VanishMax self-assigned this Jan 23, 2025
@VanishMax VanishMax moved this from 📝 Todo to 🏗 In progress in Penumbra web Jan 23, 2025
VanishMax added a commit that referenced this issue Jan 28, 2025
@VanishMax
feat(wasm): #1989: change isControlledAddress method to `getIndexBy…
2350c09 
…Address`
VanishMax added a commit that referenced this issue Jan 28, 2025
@VanishMax
feat(types): #1989: change isControlledAddress method to `getIndexB…
b045f75 
…yAddress`
VanishMax added a commit that referenced this issue Jan 28, 2025
@VanishMax
feat(protobuf): #1989: sync latest changes in penumbra protobufs
3b44f94
VanishMax added a commit that referenced this issue Jan 28, 2025
@VanishMax
feat(storage): #1989: add subaccount filter to getOwnedPositionIds …
8d6b007 
…method
VanishMax added a commit that referenced this issue Jan 28, 2025
@VanishMax
feat(services): #1989: add subaccount filter to ownedPositionIds me…
fd51582 
…thod in viewService
This was referenced Jan 28, 2025
Merged
Merged
VanishMax added a commit that referenced this issue Jan 29, 2025
@VanishMax
feat: #1989: subaccount filter in ownedPositionIds (#2006)
29dd11a 
* feat(wasm): #1989: change `isControlledAddress` method to `getIndexByAddress`

* feat(types): #1989: change `isControlledAddress` method to `getIndexByAddress`

* feat(protobuf): #1989: sync latest changes in penumbra protobufs

* feat(storage): #1989: add subaccount filter to `getOwnedPositionIds` method

* feat(services): #1989: add subaccount filter to `ownedPositionIds` method in viewService

* chore: changeset

* fix(wasm): lint

* revert(wasm, types): use the previous version of wasm methods

* fix(storage): update idb tests
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VanishMax VanishMax

Labels
priority Important to work on next
Projects
Penumbra web
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #1989: subaccount filter in ownedPositionIds penumbra-zone/web
2 participants
@erwanor @VanishMax