Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding numeraire selection #1231

Closed
grod220 opened this issue May 31, 2024 · 1 comment · Fixed by #1282 or prax-wallet/prax#28
Closed

Onboarding numeraire selection #1231

grod220 opened this issue May 31, 2024 · 1 comment · Fixed by #1282 or prax-wallet/prax#28
Assignees

Comments

@grod220
Copy link
Contributor

grod220 commented May 31, 2024

The Prax registry currently provides default numeraires. These values are important given the block processor will be referencing these as it saves swaps to the PRICING tables in indexeddb.

At the moment, there is no way for users to change these.

Proposal

In onboarding, we add a numeraire selection step. It will be populated by choices (can select multiple) from the Prax registry. It also should not communicated as "Choose your numeraire", but use text that clearly associates this selection with the pricing their see in minifront. Something like: "In which token denomination would you prefer to price assets?"

This selection should also be featured in the extension's settings to allow them to change it. Making a change should likely require restarting the block processor (or ext services) so it pulls in the latest values and saves those to the DB. We should also likely invalidate entries in the PRICING table related to the numeraire we removed.

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web May 31, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web May 31, 2024
@Valentine1898
Copy link
Contributor

We need to be careful that our onboarding flow doesn't become too complicated and lengthy
Configuring numeraire has also been discussed here #1063

@Valentine1898 Valentine1898 self-assigned this Jun 4, 2024
@Valentine1898 Valentine1898 moved this from 📝 Todo to 🏗 In progress in Penumbra web Jun 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants