Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Tracking issue: add React components for Penumbra action views #18

Open
4 of 22 tasks
hdevalence opened this issue Jul 3, 2023 · 0 comments
Open
4 of 22 tasks

Comments

@hdevalence
Copy link
Member

hdevalence commented Jul 3, 2023

In #16 I added react components for spend and action views, replacing the existing string concatenation code. The other actions are filled in with a default "unknown action" component. This should be extended to have components for all of the other Penumbra transaction actions:

Here's a list of the components that still need to be implemented, roughly in priority order:

  • SpendViewComponent
  • OutputViewComponent

DEX

  • SwapViewComponent for dex.v1alpha1.SwapView
  • SwapClaimViewComponent for dex.v1alpha1.SwapClaimView
  • PositionOpenComponent for dex.v1alpha1.PositionOpen
  • PositionCloseComponent for dex.v1alpha1.PositionClose
  • PositionWithdrawComponent for dex.v1alpha1.PositionWithdraw
  • PositionRewardClaimComponent for dex.v1alpha1.PositionRewardClaim

For now, we can skip reward claims.

In pcli, we have logic to interpret Penumbra LP positions as limit orders. We will port this logic to typescript for use in position rendering in #19.

Staking

  • DelegateComponent for stake.v1alpha1.Delegate
  • UndelegateComponent for stake.v1alpha1.Undelegate
  • UndelegateClaimComponent for stake.v1alpha1.UndelegateClaim
  • ValidatorDefinitionComponent for stake.v1alpha1.ValidatorDefinition

This is necessary to implement staking.

IBC

  • IbcActionComponent for ibc.v1alpha1.IbcAction
  • Ics20WithdrawalComponent for ibc.v1alpha1.Ics20Withdrawal

To start, rather than trying to implement rendering of all of the different IBC actions that can be bundled in an IbcAction, we should just render the proto Any type (for use in inspection / debugging of IBC functionality).

Governance

  • ProposalSubmitComponent for governance.v1alpha1.ProposalSubmit
  • ProposalWithdrawComponent for governance.v1alpha1.ProposalWithdraw
  • ValidatorVoteComponent for governance.v1alpha1.ValidatorVote
  • DelegatorVoteViewComponent for DelegatorVoteView
  • ProposalDepositClaimComponent for governance.v1alpha1.ProposalDepositClaim
  • DaoSpendComponent for governance.v1alpha1.DaoSpend
  • DaoOutputComponent for governance.v1alpha1.DaoOutput
  • DaoDepositComponent for governance.v1alpha1.DaoDeposit

These are relatively less important than the other actions.

@erwanor erwanor added this to Testnets Jul 5, 2023
@erwanor erwanor moved this to Tracking Issues in Testnets Jul 5, 2023
@erwanor erwanor changed the title Add React components for Penumbra action views Tracking issue: add React components for Penumbra action views Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Tracking Issues
Development

No branches or pull requests

1 participant