bug: cnidarium metrics emission broken #5004
Comments
This was referenced Jan 25, 2025
erwanor
added a commit
to penumbra-zone/cnidarium
that referenced
this issue
Jan 27, 2025
This fixes penumbra-zone/penumbra#5004, and prepares a new release.
conorsch
added a commit
that referenced
this issue
Jan 27, 2025
Tacks on a new integration test to catch metrics regressions, rather than waiting until post-deploy. The test is straightforward: GET the metrics endpoint, confirm a few matches. More subtle is the reordering of the smoke test suite: the pd tests come last now, since the metrics will be empty on pd start, if no work has been performed. Refs #3780, #5004.
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
pdno longer emits mostcnidarium-related metrics.Expected behavior
cnidarium-related metrics are still exposed by pd for scraping by prometheus.
Screenshots
See the time series above. The drop-off in metrics coincides with the release of v1, in which we started depending on the out-of-tree cnidarium crate.
Additional context
Given the namespacing changes, we'll need to refine how pd access the metrics exposed by the now-external cnidarium crate.
The text was updated successfully, but these errors were encountered: