Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pindexer: don't put empty reserves on dex_lp_update close events #4867

Closed
cronokirby opened this issue Sep 27, 2024 · 1 comment
Closed

pindexer: don't put empty reserves on dex_lp_update close events #4867

cronokirby opened this issue Sep 27, 2024 · 1 comment
Assignees
Labels
A-indexing Area: Relates to event indexing. needs-refinement unclear, incomplete, or stub issue that needs work
Milestone

Comments

@cronokirby
Copy link
Contributor

Right now, when a position is closed, the reserves appearing in that update are empty, because the update doesn't touch the reserves.

When populating the database it would be 10x more convenient as a consumer if the reserves field were always present, so that you don't have to manually look at the previous row to figure out what the unchanged reserves are.

We should, on a close event, look up the current reserves and put that in the table, thus making those two columns of dex_lp_update non null.

This makes life in the dex explorer easier.

@cronokirby cronokirby self-assigned this Sep 27, 2024
@cronokirby cronokirby added the A-indexing Area: Relates to event indexing. label Sep 27, 2024
@cronokirby cronokirby added this to the Sprint 13 milestone Sep 27, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Sep 27, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Sep 27, 2024
@cronokirby cronokirby moved this from Backlog to Todo in Penumbra Sep 27, 2024
@aubrika
Copy link
Contributor

aubrika commented Oct 7, 2024

Closed as superseded by #4883

@aubrika aubrika closed this as completed Oct 7, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Penumbra Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexing Area: Relates to event indexing. needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Archived in project
Development

No branches or pull requests

2 participants