Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pd migrate code to abstract away boilerplate #4294

Open
aubrika opened this issue Apr 30, 2024 · 1 comment
Open

Refactor pd migrate code to abstract away boilerplate #4294

aubrika opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
A-upgrades Area: Relates to chain upgrades _P-low Priority: low

Comments

@aubrika
Copy link
Contributor

aubrika commented Apr 30, 2024

Currently the migration code features a lot of copy-pasted functions which are common to every migration, and for the purposes of ergonomics, readability and bug surface this is not ideal. This should be kept as fairly straightforward or simple refactor with a mind to facilitating future automated testing of migrations and enhancing testability.

Suggestions from backlog grooming:

  • migrations should use the APP_VERSION, which would give us idempotency for free
  • migrations should be refactored to take a StateWrite
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 30, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 30, 2024
@aubrika aubrika self-assigned this May 1, 2024
@aubrika aubrika added the _P-low Priority: low label May 8, 2024
@conorsch conorsch removed the needs-refinement unclear, incomplete, or stub issue that needs work label May 8, 2024
@conorsch
Copy link
Contributor

conorsch commented May 8, 2024

We're not prioritizing this (see p-low tag), but as we continue to write migrations, there will be ample opportunity to make the code more DRY.

@cratelyn cratelyn added the A-upgrades Area: Relates to chain upgrades label May 8, 2024
@conorsch conorsch changed the title Refactor pd migration code to abstract away boilerplate Refactor pd migrate code to abstract away boilerplate May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-upgrades Area: Relates to chain upgrades _P-low Priority: low
Projects
Status: Backlog
Development

No branches or pull requests

3 participants