You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While reviewing #4254, @hdevalence noticed that the TriggerData should encapsulate the validation boundary that it implicitly relies on. That way it can be reused in the action handlers and we will be able to simplify its API and internal impl.
Thanks a lot for the review, I think this is mergeable but I agree with your comments about TriggerData. I think we want:
Make TriggerData inner field private
Enforce parameter validation via a constructor
Use that constructor in the action handlers
Drop checked operation (since we operate behind a validation boundary)
While reviewing #4254, @hdevalence noticed that the
TriggerData
should encapsulate the validation boundary that it implicitly relies on. That way it can be reused in the action handlers and we will be able to simplify its API and internal impl.TriggerData
inner field privateOriginally posted by @erwanor in #4254 (comment)
The text was updated successfully, but these errors were encountered: