Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auction: use TriggerData for validation and simplify its api #4268

Open
Tracked by #4196
erwanor opened this issue Apr 25, 2024 · 0 comments
Open
Tracked by #4196

auction: use TriggerData for validation and simplify its api #4268

erwanor opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V2 Priority: after mainnet

Comments

@erwanor
Copy link
Member

erwanor commented Apr 25, 2024

While reviewing #4254, @hdevalence noticed that the TriggerData should encapsulate the validation boundary that it implicitly relies on. That way it can be reused in the action handlers and we will be able to simplify its API and internal impl.

Thanks a lot for the review, I think this is mergeable but I agree with your comments about TriggerData. I think we want:

  1. Make TriggerData inner field private
  2. Enforce parameter validation via a constructor
  3. Use that constructor in the action handlers
  4. Drop checked operation (since we operate behind a validation boundary)

Originally posted by @erwanor in #4254 (comment)

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 25, 2024
@erwanor erwanor added the A-auction Area: Relates to the auction component label Apr 25, 2024
@erwanor erwanor self-assigned this Apr 25, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 25, 2024
@erwanor erwanor added _P-V1 Priority: slated for V1 release _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 25, 2024
@erwanor erwanor moved this from Backlog to Todo in Penumbra Apr 25, 2024
@erwanor erwanor added this to the Sprint 5 milestone Apr 25, 2024
@aubrika aubrika added the friction something made this fall into the following milestone & the reason should be noted in a comment label May 6, 2024
@aubrika aubrika modified the milestones: Sprint 5, Sprint 6 May 6, 2024
@cratelyn cratelyn removed the friction something made this fall into the following milestone & the reason should be noted in a comment label May 6, 2024
@cratelyn cratelyn modified the milestones: Sprint 6, Sprint 7 May 21, 2024
@erwanor erwanor moved this from Todo to In progress in Penumbra May 21, 2024
@erwanor erwanor moved this from In progress to Todo in Penumbra May 24, 2024
@aubrika aubrika added _P-V2 Priority: after mainnet and removed _P-V1 Priority: slated for V1 release labels May 30, 2024
@aubrika aubrika modified the milestones: Sprint 7, Sprint 8 Jun 3, 2024
@aubrika aubrika moved this from Todo to Backlog in Penumbra Jun 3, 2024
@aubrika aubrika removed this from the Sprint 8 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V2 Priority: after mainnet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants