Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auction: end_block implementation #4240

Closed
Tracked by #4196
erwanor opened this issue Apr 19, 2024 · 1 comment
Closed
Tracked by #4196

auction: end_block implementation #4240

erwanor opened this issue Apr 19, 2024 · 1 comment
Assignees
@erwanor
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release

Comments

@erwanor
Copy link
Member

erwanor commented Apr 19, 2024 •
edited
Loading

The pricing/auction management logic that runs every block.

I am actively working on this, iterating offline for now because the specific implementation is still "fluid" at this point.
@erwanor erwanor mentioned this issue Apr 19, 2024
Open
50 tasks
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 19, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 19, 2024
@erwanor erwanor added _P-V1 Priority: slated for V1 release _P-high High priority A-auction Area: Relates to the auction component and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 19, 2024
@erwanor erwanor self-assigned this Apr 19, 2024
@erwanor erwanor moved this from Backlog to In progress in Penumbra Apr 19, 2024
@erwanor erwanor changed the title auction: end_blockimplementation auction: end_block implementation Apr 19, 2024
@erwanor erwanor mentioned this issue Apr 22, 2024
Merged
1 task
erwanor added a commit that referenced this issue Apr 25, 2024
@erwanor
auction: implement Dutch auction execution (#4254)
1253187 
## Describe your changes

This PR implements #4240, in particular it adds the "end block" DA
auction logic, and:
- extend the auction with a `HandleDutchTriggers` trait, responsible for
streaming auction state recorded for execution at a `trigger_height`
- implement `execute_dutch_auction`, which encapsulate auction LP logic
and state updates
- add price interpolation logic
- create `penumbra_dex::lp::Position` to take a user specified random
nonce (computed based off the auction description, step index, and a
counter, in order to evade id-squatting)
- encapsulate `TriggerData` into its own submodule (DA step function
utils)

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > This is consensus breaking
@erwanor
Copy link
Member Author

erwanor commented Apr 26, 2024

Done in #4254

@erwanor erwanor closed this as completed Apr 26, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erwanor