Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated options in cometbft config template #3144

Open
hdevalence opened this issue Oct 3, 2023 · 2 comments
Open

Deprecated options in cometbft config template #3144

hdevalence opened this issue Oct 3, 2023 · 2 comments
Assignees
@conorsch
Labels
_P-low Priority: low

Comments

@hdevalence
Copy link
Member

Describe the bug

Recent smoke test runs showed

I[2023-10-03|21:23:02.579] deprecated usage found in configuration file usage="[fastsync] table detected. This section has been renamed to [blocksync]. The values in this deprecated section will be disregarded."
I[2023-10-03|21:23:02.579] deprecated usage found in configuration file usage="fast_sync key detected. This key has been renamed to block_sync. The value of this deprecated key will be disregarded."

This key is generated as part of pd's config generation mechanism.
@conorsch conorsch self-assigned this Oct 4, 2023
@conorsch conorsch moved this to Next (Steal from here) in Testnets Oct 4, 2023
@conorsch
Copy link
Contributor

conorsch commented Oct 4, 2023

Good call. I've generated a new default cometbft config via cometbft init and diffed against ours. The changes we want to pull in are pretty obvious, as are the exceptions.

@conorsch conorsch moved this from Next (Steal from here) to In Progress (Already claimed) in Testnets Oct 4, 2023
conorsch added a commit that referenced this issue Oct 4, 2023
@conorsch
chore: update cometbft config template
7e51ba7 
As of CometBFT v0.37.x, fastsync has been renamed to blocksync, and soon
it'll be mandatory. To update our config, I ran `cometbft init` and
manually reviewed the diff, to pull in updates, otherwise preserving
our custom values.

Closes #3144. Refs #2263.
@conorsch conorsch mentioned this issue Oct 4, 2023
Merged
@conorsch
Copy link
Contributor

conorsch commented Oct 4, 2023

Looked into this some more. Turns out we can't perform the rename because tendermint-config hardcodes fastsync, so in order for us to leverage the strong typing of the config (#1827), we must have that key in config. I filed an upstream issue informalsystems/tendermint-rs#1368. For now, I'll kick this into future queue so we can follow up later.

@conorsch conorsch moved this from In Progress (Already claimed) to Future in Testnets Oct 4, 2023
conorsch added a commit that referenced this issue Oct 4, 2023
@conorsch
chore: update cometbft config template
0ff4bf9 
As of CometBFT v0.37.x, fastsync has been deprecated in favor of blocksync,
but v0.38.x will disregard both options. We can't yet update the value since
we're on v0.37.x still, but I'm still pulling in the config file changes
to comments and explanations created by diffing a newly generated
CometBFT config against our TOML template.

Refs #3144. Refs #2263.
conorsch added a commit that referenced this issue Oct 4, 2023
@conorsch
chore: update cometbft config template
6e80e4b 
As of CometBFT v0.37.x, fastsync has been deprecated in favor of blocksync,
but v0.38.x will disregard both options. We can't yet update the value since
we're on v0.37.x still, but I'm still pulling in the config file changes
to comments and explanations created by diffing a newly generated
CometBFT config against our TOML template.

Refs #3144. Refs #2263.
conorsch added a commit that referenced this issue Oct 5, 2023
@conorsch
chore: update cometbft config template
bb2089f 
As of CometBFT v0.37.x, fastsync has been deprecated in favor of blocksync,
but v0.38.x will disregard both options. We can't yet update the value since
we're on v0.37.x still, but I'm still pulling in the config file changes
to comments and explanations created by diffing a newly generated
CometBFT config against our TOML template.

Refs #3144. Refs #2263.
@aubrika aubrika added this to Penumbra Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Oct 30, 2023
@hdevalence hdevalence moved this from 🗄️ Backlog to Blocked in Penumbra Feb 8, 2024
@aubrika aubrika added the _P-low Priority: low label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorsch conorsch

Labels
_P-low Priority: low
Projects
Penumbra
Status: Blocked
Testnets
Status: Future
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hdevalence @conorsch @aubrika