Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more possibilities on game score formats #117

Closed
Lysuo opened this issue Jan 11, 2025 · 4 comments
Closed

Add more possibilities on game score formats #117

Lysuo opened this issue Jan 11, 2025 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@Lysuo
Copy link

Lysuo commented Jan 11, 2025

Hi @pedrorijo91

First of all thanks for the great work, the app works really well!
After a few weeks of testing it I wanted to suggest some changes, based on my use

On the game score format:

  • in some tournaments (FR, amateur level) we may have games with sets of 9 games, the winner is the first to reach 9 (with tie break in case of 8/8)
  • in some other tournaments, we may have 3 sets, but in case it reaches the 3rd it is in fact a super tie-break in 10 points

I found a link that resumes all possible formats : https://padel-magazine.co.uk/le-score-au-padel-mode-demploi/

Do you think that during the setting screens when starting the activity it could be possible to add options to cover all this ? number of games in the set, and whether the decisive set is a regular one or a tie break with x points ?
Or maybe in case of decisive set it could be simpler to add a screen to pick the right option at 1-1 or 2-2 (super tie-break, regular set, ..) ?

Thanks

@Lysuo
Copy link
Author

Lysuo commented Jan 11, 2025

Seems related to existing #27 and #77

@pedrorijo91
Copy link
Owner

hey @Lysuo :)

indeed, the first bullet is already covered in #77 . I'm trying to find some time to refactor the code to make it easier to add new game formats. if you look at the code you can see that currently it's a bunch of if statements, which makes it a bit messy and hard to change without adding bugs 😄 this is the pre-work needed to properly support #27

regarding the second bullet, it is already supported if I understood correctly. it is also the game mode used in official tournaments (managed by Portuguese federation): 3 sets, the last one in super tie if it reaches 1-1. You just need to select 3 sets, and then super tie, in the config options

@pedrorijo91 pedrorijo91 added the duplicate This issue or pull request already exists label Jan 11, 2025
@Lysuo
Copy link
Author

Lysuo commented Jan 12, 2025

Indeed you're right for the 2nd bullet point. I usually go for unlimited sets so I had forgotten the option was here when selecting 3 and 5 sets.

I guess this ticket could be closed as duplicate then ?
So far I've never played with the C1, C2 or E formats as described in the link I posted, so I guess it's not a priority to add support for this.

@pedrorijo91
Copy link
Owner

will revisit the game formats described when implementing #27 . thanks for the contributions! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants