Dav support #47
Open
Dav support #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcorless
reviewed
Oct 15, 2020
viewer/viewer-awt/pom.xml
Outdated
| <version>5.9</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.sun.xml.bind</groupId> |
There was a problem hiding this comment.
I think this is going to be deprecated pretty soon. Can you use javax.xml.bind.* instead?
There was a problem hiding this comment.
Okay, I looked at this post and added the dependencies.
Not sure if there is a real difference between javax.xml.bind and jakarta.xml.bind.
|
I've been reviewing this of the last couple nights. There are a couple fairly complex conflicts in the SwingController related to the save changes to a temp file and webDav. Given the age of this PR could you take a closer look at these conflicts? |
|
I'll check it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #43
Closes #46
TODO : save password somehow?