Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects that panic on non empty drop should check if the thread isn't panicing already #44

Closed
IBims1NicerTobi opened this issue Jan 11, 2025 · 0 comments · Fixed by #45
Assignees
Labels
enhancement New feature or request

Comments

@IBims1NicerTobi
Copy link
Collaborator

Some objects like this panic if they are not empty when dropped. This is fine for catching errors, however they also panic when getting dropped because of another panic, which is undesired and can be fixed by checking for panicking in std::thread before the check

@IBims1NicerTobi IBims1NicerTobi self-assigned this Jan 11, 2025
@IBims1NicerTobi IBims1NicerTobi added the enhancement New feature or request label Jan 11, 2025
@IBims1NicerTobi IBims1NicerTobi linked a pull request Jan 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant