Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging - modeling dependencies in setup.py and/or move to newer project builders #7

Open
danizen opened this issue Jun 28, 2022 · 2 comments
Open

Packaging - modeling dependencies in setup.py and/or move to newer project builders #7

danizen opened this issue Jun 28, 2022 · 2 comments

Comments

@danizen
Copy link

danizen commented Jun 28, 2022

setup.py should declare the packages you depend on so that pip will install these.
@danizen
Copy link
Author

danizen commented Jun 28, 2022

Its also probably a good idea to do this in setup.cfg and user a pyproject.toml to choose a builder for the project rather than to continue to use setup.py as a command-line.

@danizen danizen changed the title Modeling dependencies in setup.py and new project issues Packaging - modeling dependencies in setup.py and/or move to newer project builders Jun 28, 2022
@danizen danizen mentioned this issue Jun 28, 2022
Open
@pawelsikora
Copy link
Owner

Thanks, added in setup.py in commit:
e35c4bf0ccfec838bc79ece82fdb232c76349bea

And pushed it with v0.2.6. Next step I will look into your second comment, so keeping it open for now.

Appreciate your feedback Dan!

Regards,
Pawel

allanger added a commit to allanger/mkdocs-with-confluence that referenced this issue Feb 28, 2023
@allanger
Update variable naming (pawelsikora#7)
162cb4a 
Co-authored-by: Nikolai Rodionov <[email protected]>
Reviewed-on: https://git.badhouseplants.net/allanger/mkdocs-with-confluence/pulls/7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danizen @pawelsikora