Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: customStatusIcon does not get applied #227

Closed
jenny-s51 opened this issue Jul 24, 2024 · 1 comment · Fixed by #229
Closed

Bug: customStatusIcon does not get applied #227

jenny-s51 opened this issue Jul 24, 2024 · 1 comment · Fixed by #229

Comments

@jenny-s51
Copy link
Collaborator

Describe the problem
A clear and concise description of the problem. Which components are affected?
When TaskNode was refactored to apply TaskPill as part of #221, the customStatusIcon functionality was reverted.

Add this logic to TaskPill: 018c394#diff-3fac288e3650a6ea4569063a20a71c99144ee01382762b0e6189e16af1906d0a

How do you reproduce the problem?
Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.

In demo app, go to Pipelines -> Task Nodes. The task node applies the error icon instead of the custom icon that's set in useDemoPipelineNodes.tsx

Screenshot 2024-07-24 at 9 03 15 AM

Expected behavior
A clear and concise description of the expected behavior.
Screenshot 2024-07-24 at 9 04 51 AM

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 24, 2024
@dlabaj dlabaj moved this from Needs triage to Not started in PatternFly Issues Jul 25, 2024
@dlabaj dlabaj moved this from Not started to Needs triage in PatternFly Issues Jul 25, 2024
@dlabaj dlabaj moved this from Needs triage to Not started in PatternFly Issues Jul 25, 2024
@jenny-s51 jenny-s51 moved this from Not started to PR Review in PatternFly Issues Aug 5, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

🎉 This issue has been resolved in version 5.4.0-prerelease.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants