Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add default slot getter to SlotController #2603

Closed
brianferry opened this issue Oct 10, 2023 · 0 comments · Fixed by #2604
Closed

[core] Add default slot getter to SlotController #2603

brianferry opened this issue Oct 10, 2023 · 0 comments · Fixed by #2604
Assignees
@brianferry
Labels
feature New feature or request pfe 2.5 For PFE version 2.5 priority: low Severity level: 3
Milestone
PatternFly Elemen...

Comments

@brianferry
Copy link
Collaborator

Description of the requested feature

SlotController needs to be able to get the default slot and check if it has content. We also want to be able to add functionality such as .isEmpty to the slot controller to check for during templating.
@brianferry brianferry added feature New feature or request priority: low Severity level: 3 labels Oct 10, 2023
@brianferry brianferry mentioned this issue Oct 10, 2023
Merged
@brianferry brianferry self-assigned this Oct 10, 2023
@brianferry brianferry linked a pull request Oct 10, 2023 that will close this issue
feat(core): adding isEmpty, hasSlotted w/ default slot #2604
Merged
@bennypowers bennypowers added this to the PatternFly Elements 3 milestone Oct 18, 2023
@bennypowers bennypowers moved this from Backlog to In Progress 🟢 in Red Hat Design System Oct 18, 2023
@bennypowers bennypowers moved this from In Progress 🟢 to Review 🔍 in Red Hat Design System Oct 18, 2023
@markcaron markcaron added the pfe 2.5 For PFE version 2.5 label Oct 19, 2023
@github-project-automation github-project-automation bot moved this from Review 🔍 to Done ☑️ in Red Hat Design System Dec 4, 2023
@github-project-automation github-project-automation bot moved this to In Progress - precarious in PF Roadmap Dec 4, 2023
@github-actions github-actions bot mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianferry brianferry

Labels
feature New feature or request pfe 2.5 For PFE version 2.5 priority: low Severity level: 3
Projects
PF Roadmap
Status: No status
Milestone
PatternFly Elements 3
Development

Successfully merging a pull request may close this issue.

feat(core): adding isEmpty, hasSlotted w/ default slot patternfly/patternfly-elements
3 participants
@bennypowers @markcaron @brianferry