Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching logic is unspecified #63

Open
apasel422 opened this issue Jan 8, 2025 · 1 comment
Open

Matching logic is unspecified #63

apasel422 opened this issue Jan 8, 2025 · 1 comment

Comments

@apasel422
Copy link

Per the TODO at https://patcg.github.io/ppa-api/#logic-matching.

I'd be happy to open a PR to try and address this.
@andyleiserson
Copy link
Collaborator

PR would be welcome, thanks.

I think the TODO was written before the text that is currently in that section, but the text that's there still isn't sufficient -- the lack of clarity around filter data that you've noted, and it's also missing any discussion of intermediarySites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apasel422 @andyleiserson