Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve development setup for embed #33

Open
supermacro opened this issue Apr 17, 2021 · 0 comments
Open

Improve development setup for embed #33

supermacro opened this issue Apr 17, 2021 · 0 comments

Comments

@supermacro
Copy link
Member

The embed currently requires changing a hard-coded embedAppOrigin variable in the demo/index.html page based on whether we are running locally or deploying to production.

Additionally, the developer needs to manually cd into the /demo directory and run a web server to serve this demo host index html page and subsequently run another process to serve up the elm embed application on a separate port.

Additionally, the developer needs to have elm already installed.

Lastly, the node version is not pinned down.

This all seems a little annoying / cumbersome.

Desired Outcome:

  • There should be just one command to do all this work for a developer, namely npm install
  • There should be environment variables set in demo/index.html so that we don't have to hardcode values and not have an error prone deployment process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant