[ExternalPluginNotifier] Replacements looks to be required when it shouldn't be and getting client thread error

[adamk33n3r]

Checklist

• I'm reporting a problem with Dink
• I've searched the issues and pull requests for similar looking reports

Describe your issue

When testing v1.11.2 I'm getting an exception that replacements can't be null even though it's not supposed to be required.

Then after adding an empty map for replacements just for testing, I get this error. Looks like it's trying to get a varbit from a non-client thread?

Screenshots

No response

Runelite Logs

client.log

Runelite Version

1.11.3

[pajlada]

#676 will fix the replacements issue

For the client thread issue, we've previously assumed enrichBody will either be called from the client thread, or that the account type is already filled in.

If that's the only place where we do client-thread-only access to data, we might just want to cache the account type ourselves & allow for any thread to access that data.

Any thoughts on preferred approach for that @iProdigy ?

[iProdigy]

there's more data being queried within enrichBody that should be done from the client thread; will make a PR to ensure it's not called off-thread

[adamk33n3r]

there's more data being queried within enrichBody that should be done from the client thread; will make a PR to ensure it's not called off-thread

Just for transparency, my two tests were from the swing thread, and from my own thread (triggered by a game message event) which I guess makes sense. All of my notifications get put onto a thread of their own so they don't cause any game lag (sounds and tts were doing that).

[pajlada]

there's more data being queried within enrichBody that should be done from the client thread; will make a PR to ensure it's not called off-thread

Just for transparency, my two tests were from the swing thread, and from my own thread (triggered by a game message event) which I guess makes sense. All of my notifications get put onto a thread of their own so they don't cause any game lag (sounds and tts were doing that).

That's perfectly fine, we'll invoke the relevant part in the client thread now https://github.com/pajlads/DinkPlugin/pull/677/files

[adamk33n3r]

Can confirm it works now