Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cancelling Testing Farm requests by users #2336

Open
1 of 2 tasks
janhavlin opened this issue Feb 8, 2024 · 7 comments
Open
1 of 2 tasks

Add support for cancelling Testing Farm requests by users #2336

janhavlin opened this issue Feb 8, 2024 · 7 comments
Labels
area/testing-farm Related to Testing Farm integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.

Comments

@janhavlin
Copy link

Description

After some recent changes to auth on the Testing Farm API, users are not able to use the delete endpoint to cancel requests that were submitted on their behalf by Packit - only Packit is authorized to cancel TF requests created by Packit. Due to this limitation, implementing support for TF request cancelling on Packit's side deems most suitable.

Benefit

Users will be able to cancel their TF requests.

Importance

No response

What is the impacted category (job)?

Testing Farm tests

Workaround

  • There is an existing workaround that can be used until this feature is implemented.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@janhavlin janhavlin added the kind/feature New feature or a request for enhancement. label Feb 8, 2024
@janhavlin
Copy link
Author

@Frawless @kornys

@lbarcziova
Copy link
Member

hi @janhavlin. This makes sense to me and would be a nice improvement.

As for the implementation, it could be a new comment command (e.g. `/packit test-cancel ) or something similar to #1595, but that is only for GitHub. In any case, we need to check the "permissions" to cancel the particular request for the person who triggers it.

@lachmanfrantisek lachmanfrantisek added complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. area/testing-farm Related to Testing Farm integration. labels Feb 12, 2024
@lbarcziova lbarcziova moved this from new to backlog in Packit Kanban Board Feb 12, 2024
@kkaarreell
Copy link

This would be really great to have. It might also help to "decrease" cloud costs. Could you maybe consider planning it for implementation?

@LecrisUT
Copy link
Contributor

LecrisUT commented Oct 7, 2024

Also worth considering GH Action's concurrency option. Basically if you set it, then it would cancel all previous jobs that have the same github.ref (e.g. this would be the PR reference) . Would be nice to make packit do this by default, or have an option to enable such logic.

@thrix
Copy link
Contributor

thrix commented Dec 10, 2024

@lbarcziova any update here pls? I think packit should cancel also requests in case something is running and rerun is scheduled

@lbarcziova
Copy link
Member

@thrix hi, no update unfortunately, though you are right we should consider this for next quarter, in particular what you mean is probably #5, right?

@thrix
Copy link
Contributor

thrix commented Dec 10, 2024

yeah, #5, cool thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing-farm Related to Testing Farm integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.
Projects
Status: backlog
Development

No branches or pull requests

6 participants