fix(transformer/typescript): remove type-only import = when only_remove_type_imports is true
#8275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-transformer
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
import =import = when only_remove_type_imports is true
CodSpeed Performance ReportMerging #8275 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
01-06-fix_transformer_typescript_remove_type-only_import_
branch
2 times, most recently
from
37b9c95 to
939063e
Compare
Boshen
reviewed
Jan 6, 2025
Dunqing
force-pushed
the
01-06-fix_transformer_typescript_remove_type-only_import_
branch
from
939063e to
60102a5
Compare
underfin
reviewed
Jan 7, 2025
...onformance/tests/babel-plugin-transform-typescript/test/fixtures/preserve-import-=/output.js
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #8230
close: rolldown/rolldown#3287
Related PR in Babel: #8230
I have compared our output with TypeScript, and it is the same as
TypeScript, Babel's implementation currently hasn't removed imports referenced by type-onlyTSImportEqualsDeclaration