Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Test Case: Assess consistent versioning #220

Open
corbanvilla opened this issue Jul 5, 2022 · 0 comments
Open

Test Case: Assess consistent versioning #220

corbanvilla opened this issue Jul 5, 2022 · 0 comments
Labels
C-all Contract-all P-low Priority-low T-bug Type: bug

Comments

@corbanvilla
Copy link
Contributor

corbanvilla commented Jul 5, 2022

Setup the versioning testcase to pull directly from package.json.

Bonus Points

Write a script callable from package.json which uses sed to automatically update the version() return in all contracts.
Note: Some contracts use _version as the constant (ERC721Attributes) but most others use version as a public constant. Make sure to address both cases.

Subpackage package.json versions should be updated as well!

Extra Bonus Points

Extra bonus points if it's a Hardhat task where by default it only shows the changes it would make and allows the user to verify before running. Look for the -i flag under man sed.

@corbanvilla corbanvilla mentioned this issue Jul 5, 2022
11 tasks
@HrikB HrikB added P-low Priority-low T-bug Type: bug C-all Contract-all and removed low priority labels Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-all Contract-all P-low Priority-low T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

2 participants