Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is great! #1

Open
edenman opened this issue Jan 23, 2020 · 3 comments
Open

This is great! #1

edenman opened this issue Jan 23, 2020 · 3 comments

Comments

@edenman
Copy link

edenman commented Jan 23, 2020

Are there any known issues to justify "Do not use in production"? Seems to work great.

@owahltinez
Copy link
Owner

Thanks for the feedback :)

A few reasons not to use it in production yet, in no particular order:

  • The library used to control the camera, CameraX, is currently in alpha
  • There's a lot of key functionality missing like tap-to-focus, flash, zoom...
  • This library has not gone through a proper engineering review (but it will soon)
  • This library is not in Maven yet, but will hopefully eventually become part of CameraX

That said, if you are brave enough to try it, please provide feedback and open issues. Or, if you end up forking it because it didn't fit your particular purpose, that would be interesting for me to learn about as well.

@edenman
Copy link
Author

edenman commented Jan 24, 2020

Gotcha, thanks for the reply! Would you be open to PRs to add tap-to-focus/flash/zoom? That's the only thing in this list that is at all concerning to me.

@owahltinez
Copy link
Owner

Yes, we are open to pull requests :)

But, keep in mind that some of those APIs will change in beta. For example, I was waiting for a new metering point factory compatible with PreviewView to implement tap-to-focus.

We can also be a little picky about code style and UX, but if you are willing to work with us when you submit a PR don't feel discouraged from doing so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants