Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the submitter code #32

Open
tomverran opened this issue Mar 30, 2020 · 0 comments
Open

Improve the submitter code #32

tomverran opened this issue Mar 30, 2020 · 0 comments

Comments

@tomverran
Copy link
Contributor

The submitter uses a Fiber to run a background task which means we have to use a Semaphore to ensure it isn't stopped between removing data from the queue & submitting it when the app shuts down.

My theory is we could operate at a slightly higher level and use FS2 for this but it needs some careful consideration to ensure we don't introduce any new race conditions. I have a branch I can produce upon request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant