Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a tag "albumartist" to keep directory structure clean #68

Open
etychon opened this issue Jan 22, 2025 · 2 comments
Open

Need a tag "albumartist" to keep directory structure clean #68

etychon opened this issue Jan 22, 2025 · 2 comments
Labels
invalid This doesn't seem right

Comments

@etychon
Copy link

etychon commented Jan 22, 2025

Right now, when an album is downloaded it uses the track artist(s) and not the album artist.

For instance when I do this:
$ tiddl -q master -p download -o "{artist}/{album}/{number} - {artist} - {title}" https://tidal.com/browse/album/83786194\?u

It ends up creating this structure which is not ideal:

download
├── Alex Campbell
│   └── Behind the Mix
│       ├── 7 - Alex Campbell - When I Paint My Masterpiece.flac
│       └── cover.jpg
├── Allan Taylor
│   └── Behind the Mix
│       ├── 12 - Allan Taylor - The Story of Portland Town.flac
│       ├── 14 - Allan Taylor - Allan Taylor Says Goodbye to Derroll.flac
│       ├── 1 - Allan Taylor - Nadine.flac
│       ├── 2 - Allan Taylor - The Tennessee Waltz.flac
│       ├── 3 - Allan Taylor - Save the Last Dance for Me.flac
│       ├── 4 - Allan Taylor - Thinking of Derroll Adams.flac
│       ├── 5 - Allan Taylor - Banjo Man.flac
│       ├── 6 - Allan Taylor - Thinking of Alex Campbell.flac
│       ├── 8 - Allan Taylor - Take Me with You, Ally.flac
│       ├── 9 - Allan Taylor - Allan Taylor and Derroll Adams.flac
│       └── cover.jpg
├── Allan Taylor, Derroll Adams
│   └── Behind the Mix
│       ├── 10 - Allan Taylor, Derroll Adams - Trouble in Mind.flac
│       ├── 11 - Allan Taylor, Derroll Adams - Let It Come, Let It Go.flac
│       ├── 13 - Allan Taylor, Derroll Adams - Portland Town.flac
│       └── cover.jpg
└── Derroll Adams
    └── Behind the Mix
        ├── 15 - Derroll Adams - Memories.flac
        └── cover.jpg

I'd rather prefer the whole thing to be made under the same {albumartist} directory like so:

download
└── Allan Taylor
    └── Behind the Mix
        ├── 10 - Allan Taylor, Derroll Adams - Trouble in Mind.flac
        ├── 11 - Allan Taylor, Derroll Adams - Let It Come, Let It Go.flac
        ├── 12 - Allan Taylor - The Story of Portland Town.flac
        ├── 13 - Allan Taylor, Derroll Adams - Portland Town.flac
        ├── 14 - Allan Taylor - Allan Taylor Says Goodbye to Derroll.flac
        ├── 15 - Derroll Adams - Memories.flac
        ├── 1 - Allan Taylor - Nadine.flac
        ├── 2 - Allan Taylor - The Tennessee Waltz.flac
        ├── 3 - Allan Taylor - Save the Last Dance for Me.flac
        ├── 4 - Allan Taylor - Thinking of Derroll Adams.flac
        ├── 5 - Allan Taylor - Banjo Man.flac
        ├── 6 - Allan Taylor - Thinking of Alex Campbell.flac
        ├── 7 - Alex Campbell - When I Paint My Masterpiece.flac
        ├── 8 - Allan Taylor - Take Me with You, Ally.flac
        ├── 9 - Allan Taylor - Allan Taylor and Derroll Adams.flac
        └── cover.jpg
@oskvr37 oskvr37 added the invalid This doesn't seem right label Jan 22, 2025
oskvr37 added a commit that referenced this issue Jan 23, 2025
@oskvr37
Copy link
Owner

oskvr37 commented Jan 23, 2025

Thanks for submitting.

The {album_artist} tag will be added in tiddl 2.0 and the tag will be set to main album artist.

But there will be issue when album has more than one main artist like Without Warning by 21 Savage, Offset and Metro Boomin. I will be working on it

@oskvr37
Copy link
Owner

oskvr37 commented Jan 28, 2025

$ tiddl url https://listen.tidal.com/album/80611906 download -q low -o "{album_artist}/{title}"
★ Album Without Warning
✔ Downloading track 21 Savage/Ghostface Killers (feat. Travis Scott)

Data from Tidal API:

"artist": {
  "id": 7279286,
  "name": "21 Savage",
  "type": "MAIN",
  "picture": "7b875bcb-fb00-460e-a94c-7e5c15ddd9f8"
},
"artists": [
  {
    "id": 7279286,
    "name": "21 Savage",
    "type": "MAIN",
    "picture": "7b875bcb-fb00-460e-a94c-7e5c15ddd9f8"
  },
  {
    "id": 3958646,
    "name": "Offset",
    "type": "MAIN",
    "picture": "4ff82675-f0bc-4aea-97f3-4a4446e965d5"
  },
  {
    "id": 5012586,
    "name": "Metro Boomin",
    "type": "MAIN",
    "picture": "1117eb24-93a9-410c-a603-a897c86d3db7"
  }
]

Image

Currently tiddl treats an artist from Tidal API as the album artist, despite there are 3 "MAIN" artists on the album.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants