Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Kernel step basics (HMS-5198) #2685

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Dec 13, 2024

This adds foundation for Kernel step, including gating and basic tests.

JIRA: HMS-5198

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5192

@schutzbot schutzbot changed the title Wizard: Kernel step basics Wizard: Kernel step basics (HMS-5198) Dec 13, 2024
Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This adds foundation for Kernel step, including gating and basic tests.
@regexowl regexowl enabled auto-merge (rebase) December 16, 2024 08:40
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (8004ed7) to head (92f470e).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
+ Coverage   85.26%   85.29%   +0.02%     
==========================================
  Files         175      178       +3     
  Lines       20292    20330      +38     
  Branches     1977     1980       +3     
==========================================
+ Hits        17302    17340      +38     
  Misses       2968     2968              
  Partials       22       22              
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 99.47% <100.00%> (+0.01%) ⬆️
...Wizard/steps/Kernel/components/KernelArguments.tsx 100.00% <100.00%> (ø)
...ImageWizard/steps/Kernel/components/KernelName.tsx 100.00% <100.00%> (ø)
...omponents/CreateImageWizard/steps/Kernel/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8004ed7...92f470e. Read the comment docs.

@regexowl
Copy link
Collaborator Author

/retest

@regexowl regexowl merged commit 8e046e3 into osbuild:main Dec 16, 2024
7 checks passed
@regexowl regexowl deleted the kernel-basics branch December 16, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants