From 19baf1de64cbd8403bfa2c0be0c3c42251c2d354 Mon Sep 17 00:00:00 2001 From: Michael Grifalconi Date: Wed, 28 Feb 2024 09:56:11 +0100 Subject: [PATCH 1/2] Allow Revert commits to exceed character limit - Allow: <72chars> - Allow: Revert<72char> - Allow: Revert"<72char>" -> This is default format to revert using UI - Do not allow: "<72char>" --- .github/workflows/base-commit-message-checker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/base-commit-message-checker.yml b/.github/workflows/base-commit-message-checker.yml index f83b61a..f7d836a 100644 --- a/.github/workflows/base-commit-message-checker.yml +++ b/.github/workflows/base-commit-message-checker.yml @@ -26,7 +26,7 @@ jobs: - name: Check subject line length uses: gsactions/commit-message-checker@v2 with: - pattern: '^.{1,72}(\n|$)' + pattern: '^((Revert )?.{1,72}(\n|$)|(Revert ").{1,72}"(\n|$))' flags: 'g' error: 'The maximum subject line length of 72 characters is exceeded.' excludeDescription: 'true' From 7cc7c15ffbcdc9afd6879e223d9d480264a3b267 Mon Sep 17 00:00:00 2001 From: Michael Grifalconi Date: Wed, 28 Feb 2024 12:30:26 +0100 Subject: [PATCH 2/2] Simplify commit length check Co-authored-by: Oliver Kurz --- .github/workflows/base-commit-message-checker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/base-commit-message-checker.yml b/.github/workflows/base-commit-message-checker.yml index f7d836a..f93bd0f 100644 --- a/.github/workflows/base-commit-message-checker.yml +++ b/.github/workflows/base-commit-message-checker.yml @@ -26,7 +26,7 @@ jobs: - name: Check subject line length uses: gsactions/commit-message-checker@v2 with: - pattern: '^((Revert )?.{1,72}(\n|$)|(Revert ").{1,72}"(\n|$))' + pattern: '^(Revert "?)?.{1,72}(\n|$)' flags: 'g' error: 'The maximum subject line length of 72 characters is exceeded.' excludeDescription: 'true'