Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk failing in Pipeline due to jsonpath-plus issue #1661

Closed
GRenwickBrambles opened this issue Oct 11, 2024 · 20 comments · Fixed by #1702
Closed

Snyk failing in Pipeline due to jsonpath-plus issue #1661

GRenwickBrambles opened this issue Oct 11, 2024 · 20 comments · Fixed by #1702
Labels
bug Something isn't working

Comments

@GRenwickBrambles
Copy link

What are the steps to reproduce this issue?

Run snyk test --severity-threshold=high on package after installing

What happens?

Issues with no direct upgrade or patch:
✗ Remote Code Execution (RCE) [Critical Severity][https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884] in [email protected]
introduced by [email protected] > @orval/[email protected] > @orval/[email protected] > @ibm-cloud/[email protected] > @stoplight/[email protected] > @stoplight/[email protected] > [email protected] and 1 other path(s)
This issue was fixed in versions: 10.0.0

What were you expecting to happen?

Snyk to be fine with all Orval dependencies

Any logs, error output, etc?

https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884

Any other comments?

What versions are you using?

npmPackages:
axios: ^1.7.7 => 1.7.7
msw: ^2.4.9 => 2.4.9
orval: ^7.1.1 => 7.1.1

@melloware melloware added the bug Something isn't working label Oct 11, 2024
@melloware
Copy link
Collaborator

Updating depedencies of dependencies can be tricky but PR is welcome!

@melloware
Copy link
Collaborator

image

@Mariscal6
Copy link

it looks like the fix is there but not tagged yet

stoplightio/spectral@5205058

@melloware
Copy link
Collaborator

@Mariscal6 thanks for keeping your eye on it and let us know when its released so we can bump!

@RasmusStaal1227
Copy link

Hello @melloware, it looks like the PR has been merged :)

@melloware
Copy link
Collaborator

Nice now Spectral needs to do a release.

@jacquesg
Copy link

There is another PR that needs to land in spectral: stoplightio/spectral#2712

@melloware
Copy link
Collaborator

OK somebody let me know when Spectral releases.

@mackerson123
Copy link

@melloware looks like the PR has landed :)

@melloware
Copy link
Collaborator

Yep but spectral has not done a release yet...

@micael-mbagira-parloa
Copy link
Contributor

@melloware spectral has released the new version

@melloware
Copy link
Collaborator

I will look at this today!

@melloware
Copy link
Collaborator

PR is here but looking at it it looks like IBM OPenApiTools is what needs to update to the latest Spectral? https://github.com/orval-labs/orval/pull/1701/files

@micael-mbagira-parloa
Copy link
Contributor

@melloware correct, I will try to open a PR there tomorrow.

@jacquesg
Copy link

@melloware
Copy link
Collaborator

its actually not validator its @ibm-cloud/openapi-ruleset which I updated to 1.25.0 but still not sure that fixes it.

@jacquesg
Copy link

Indeed, I've created a PR to update the deps there:

IBM/openapi-validator#697

@jacquesg
Copy link

@melloware version 1.25.1 should now be out.

@melloware
Copy link
Collaborator

PR updated! #1702

@melloware
Copy link
Collaborator

OK 7.3.0 is out if everyone wants to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants