Add disk is getting disk mode as independent

[posttoashok]

Hi,

During VM proviison, I am trying to add a additional diks, but the disk is getting Disk mode as independent - Presistent.

Let me know how to make it as dependent by default?

I have tried as below in /var/www/miq/vmdb/app/models/vm_or_template/operations/configuration.rb

Deleted this line:-
def raw_add_disk(_disk_name, _disk_size_mb, _options = {})
raise NotImplementedError, _("must be implemented in a subclass")
end

Added this line:-
def raw_add_disk(disk_name, disk_size_mb, options = {})
raise _("VM has no EMS, unable to add disk") unless ext_management_system
options[:dependent]=true
run_command_via_parent(:vm_add_disk, :diskName => disk_name, :diskSize => disk_size_mb,
:thinProvisioned => options[:thin_provisioned], :dependent => options[:dependent], :persistent => options[:persistent])
end

but no luck

[Fryguy]

@agrare Do you know?

[agrare]

Hey @posttoashok when provisioning a VM new disks are added to the clone config spec via this method: https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/provision/configuration/disk.rb#L73-L106

The odd part is that while it is not user configurable, it is hard-coded to the "persistent" disk mode [here], not independent-persistent so I'm not sure how you're getting new disks as independent persistent.

Are the independent-persistent disks possible coming from the template and not the new disks? I will also try to reproduce on my side.

FYI here are the possible values for that diskMode attribute https://vdc-download.vmware.com/vmwb-repository/dcr-public/b50dcbbf-051d-4204-a3e7-e1b618c1e384/538cf2ec-b34f-4bae-a332-3820ef9e7773/vim.vm.device.VirtualDiskOption.DiskMode.html

[agrare]

@posttoashok I tried to reproduce this by provisioning a template with a single Dependent disk and part of the provision options add a new disk with options prov.set_option(:disk_scsi, [{:bus => 0, :pos => 1, :sizeInMB => 1024}])

The resulting VM has two disks both show up as Dependent.

I'm going to try the same but with the source template having an independent - persistent disk rather than a typical dependent disk and see if vmware forces the rest of the disks to have the same diskMode.

When the source template has an Independent - Persistent disk the new disk still is added as Dependent by default.

[posttoashok]

After i adding below given, Now I am getting add disk as persistent disk

Automate/Explorer/Custom_Domain/
vm.add_disk("[#{vm.storage_name}]", size * 1024, {:persistent=>true, :thin_provisioned=>false, :dependent=>true})

[agrare]

That's great @posttoashok, just one thing to note the :persistent and :dependent options aren't honored right now, the only option for a new disk is Dependent but it would be a nice enhancement to be able to support the same disk options as reconfigure. I will look into adding this shortly.